[Gui][HeadlessRecorder]Remove avcodec dependency in HeadlessRecorder.h #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgaugry
added
enhancement
|
Ok for backport 👍 |
guparan
added
pr: status ready
guparan
pushed a commit
to guparan/sofa
that referenced
this pull request
Oct 4, 2018
…endencies-from-headers [Gui][HeadlessRecorder]Remove avcodec dependency in HeadlessRecorder.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward declare a class, so that avcodecs headers are only required when compiling the cpp.
That way, this header can be included even if FFmpeg headers are not in context (which lead to compilation failure).
--> Can this change be also backported to 18.06 branch ?
This PR:
Reviewers will merge only if all these checks are true.