Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaPreconditioner] FIX ShewchukPCGLinearSolver #737

Merged
merged 3 commits into from
Jul 31, 2018
Merged

[SofaPreconditioner] FIX ShewchukPCGLinearSolver #737

merged 3 commits into from
Jul 31, 2018

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Jul 30, 2018 •
edited
Loading

This PR fixes ShewchukPCGLinearSolver member preconditioners initialization.
Should fix the failing scene test FEMBAR-PCGLinearSolver.scn

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@guparan guparan added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Jul 30, 2018
@guparan
Copy link
Contributor Author

guparan commented Jul 30, 2018

[ci-build][with-scene-tests]

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 31, 2018
@guparan guparan added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Jul 31, 2018
@hugtalbot hugtalbot merged commit 8ebb761 into sofa-framework:master Jul 31, 2018
@guparan guparan deleted the fix_ShewchukPCGLinearSolver branch October 1, 2018 14:10
@guparan guparan added this to the v18.12 milestone Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.12
Development

Successfully merging this pull request may close these issues.
2 participants
@guparan @hugtalbot