Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaTest] ADD a PrintTo method so test failure shows human readable informations. #730

Merged

Conversation

damienmarchal
Copy link
Contributor

@damienmarchal damienmarchal commented Jul 27, 2018

But default google test prints raw values when the tests cases are provided by GetParams.
By adding a PrintTo function this behavior can be changed so that custom types are easier
to read.

In the PR i adds a PrintTo for the Python_test_data object.


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@damienmarchal damienmarchal added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Jul 27, 2018
@damienmarchal damienmarchal added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Jul 27, 2018
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 31, 2018
@guparan guparan merged commit 312e8f8 into sofa-framework:master Aug 1, 2018
@damienmarchal damienmarchal deleted the sofa_addSofaTest_PrintTo branch August 6, 2018 15:07
@guparan guparan added this to the v18.12 milestone Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants