Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaGuiQt] Change method to allow antialiased screenshots in QtViewer #728

Merged
merged 1 commit into from
Jul 27, 2018
Merged

[SofaGuiQt] Change method to allow antialiased screenshots in QtViewer #728

merged 1 commit into from
Jul 27, 2018

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Jul 26, 2018 •
edited by guparan
Loading

Capture::screenshot() does not work with anti-aliased (MSAA) OpenGL rendering.
Using instead built-in Qt method.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@fredroy fredroy added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days labels Jul 27, 2018
@epernod
Copy link
Contributor

epernod commented Jul 27, 2018

there was no screenshot method at all in this viewer?

@fredroy
Copy link
Contributor Author

fredroy commented Jul 27, 2018

There is a method in the base class (BaseViewer), using helper::Capture.

@guparan guparan added the pr: status ready Approved a pull-request, ready to be squashed label Jul 27, 2018
@damienmarchal
Copy link
Contributor

So merge ?

@guparan guparan merged commit 834d926 into sofa-framework:master Jul 27, 2018
@guparan
Copy link
Contributor

guparan commented Jul 27, 2018

Yup, was doing multiple reviews in the same time ^^

@guparan guparan added this to the v18.12 milestone Oct 26, 2018
@guparan guparan changed the title [QtViewer (old gui) ] Change method to allow antialiased screenshots [SofaGuiQt] Change method to allow antialiased screenshots in QtViewer Oct 26, 2018
@fredroy fredroy deleted the fix_qtviewer_screenshot branch May 13, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.12
Development

Successfully merging this pull request may close these issues.
4 participants
@fredroy @epernod @damienmarchal @guparan