-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaGraphComponent] FIX SceneCheck build on MacOS #719
Merged
epernod
merged 2 commits into
sofa-framework:master
from
guparan:fix_scenecheck_macos_build
Jul 23, 2018
Merged
[SofaGraphComponent] FIX SceneCheck build on MacOS #719
epernod
merged 2 commits into
sofa-framework:master
from
guparan:fix_scenecheck_macos_build
Jul 23, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guparan
added
pr: fix
Fix a bug
pr: fast merge
Minor change that can be merged without waiting for the 7 review days
labels
Jul 16, 2018
[ci-build] |
Build failed with old error already seen in build 220. |
hugtalbot
added
the
pr: status to review
To notify reviewers to review this pull-request
label
Jul 16, 2018
[ci-build] just testing if the problem is due to the lib. |
Well done @epernod ! |
Could someone test if the AdvancedTimer is still working correctly with the new nlohmann_json version? |
No regression test on the advanceTimer? ;) |
guparan
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Jul 20, 2018
Ready to merge. |
green green green!!! |
[ci-build][with-scene-tests] |
guparan
added
the
pr: backport done
This PR has been backported into the release before its milestone.
label
Oct 4, 2018
guparan
pushed a commit
to guparan/sofa
that referenced
this pull request
Oct 4, 2018
…os_build [SofaGraphComponent] FIX SceneCheck build on MacOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: backport done
This PR has been backported into the release before its milestone.
pr: fast merge
Minor change that can be merged without waiting for the 7 review days
pr: fix
Fix a bug
pr: status ready
Approved a pull-request, ready to be squashed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI info: I disabled Defrost MacOS builder to force this PR to build on sofa-ci-dev-macos.
To be merged asap (if CI agrees).
This PR:
Reviewers will merge only if all these checks are true.