Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Fix TopologySurfaceDifferentMesh.scn #716

Merged
merged 3 commits into from
Aug 2, 2018
Merged

[examples] Fix TopologySurfaceDifferentMesh.scn #716

merged 3 commits into from
Aug 2, 2018

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Jul 16, 2018 •
edited
Loading

Fix the scene as reported in issue #681

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@epernod epernod added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days labels Jul 16, 2018
@epernod epernod self-assigned this Jul 16, 2018
@epernod epernod added the pr: status to review To notify reviewers to review this pull-request label Jul 16, 2018
@epernod
Copy link
Contributor Author

epernod commented Jul 16, 2018

[ci-build][with-scene-tests]

@epernod epernod added pr: status wip Development in the pull-request is still in progress pr: status to review To notify reviewers to review this pull-request and removed pr: status to review To notify reviewers to review this pull-request pr: status wip Development in the pull-request is still in progress labels Jul 18, 2018
@guparan guparan changed the title [Topology tutorial] Fix TopologySurfaceDifferentMesh [examples] Fix TopologySurfaceDifferentMesh.scn Jul 25, 2018
@hugtalbot
Copy link
Contributor

Ok works for me.

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Aug 1, 2018
@hugtalbot hugtalbot merged commit 6e0a396 into sofa-framework:master Aug 2, 2018
@guparan guparan added this to the v18.12 milestone Oct 26, 2018
@epernod epernod deleted the fix_topoDiffMesh_tuto branch May 4, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@epernod epernod

Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.12
Development

Successfully merging this pull request may close these issues.
3 participants
@epernod @hugtalbot @guparan