Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaBaseTopology Test] Add battery of tests on topology containers #708

Merged
merged 19 commits into from
Jul 19, 2018

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Jul 6, 2018

as promised since long time ago...

There is still a lot of work to do but here is a first set of tests on the topology containers.

  • Do not test yet the topological changes.
  • Neither more complex algo like incision.
  • Nor TopologicalData...

it is just the beginning !

FIX #43


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

epernod added 12 commits July 4, 2018 16:52
…triangleSetTopologyContainer. For the moment only test all buffer creation: triangle, edge, vertices and also cross buffer, TriangleAround vertex/edge and edgesInTriangle.
…copied in the topologyContainer. Check if 0 points will set to the size of initPoints.
…SetTopologyContainer. For the moment only test all buffer creation: edge, vertices and also cross buffer, EdgeAroundVertex.
…copied in the topologyContainer. Check if 0 points will set to the size of initPoints.
…copied in the topologyContainer. Check if 0 points will set to the size of initPoints. Fix for quad, tetra et hedra
…SetTopologyContainer. For the moment only test all buffer creation: quad, edge, vertices and also cross buffer, QuadAround vertex/edge and edgesInQuads.
…test class to test their TopologyContainer. For the moment only test all buffer creation: hexahedron/tetrahedron, quad/triangle, edge, vertices and also cross buffer, hexahedronAround Quad and Vertices, Quad and edge in Hexahedron and same for triangles with tetrahedron.

FIX: some loop limit bug
ADD: cube small mesh in tetrahedron and square1 in quads.
…t a MeshTopology instead of dynamic containers.

Add: MestTopology_test where most common getter are tested and the all topology buffers are compare to the dynamic_container one, assuming that the tests on the dynamic topology are already testing the topology itself.
@epernod epernod added location: tests pr: status wip Development in the pull-request is still in progress pr: clean Cleaning the code labels Jul 6, 2018
@epernod epernod self-assigned this Jul 6, 2018
@epernod
Copy link
Contributor Author

epernod commented Jul 6, 2018

Several tests are not passing yet due to error in the code to be fixed soon.

@damienmarchal
Copy link
Contributor

I cannot support more what you are doing, thanks Erik !

…aRepository + macro to source path + resources
@epernod epernod added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Jul 10, 2018
…de of bounds, if outside return an element filled with -1 values
…to have the good number of points in the topology.
@epernod
Copy link
Contributor Author

epernod commented Jul 10, 2018

[ci-build][with-scene-tests]

…l between MeshTopology and topoContainer. Not sure if one version is better than the other.
@hugtalbot
Copy link
Contributor

[ci-build][with-scene-tests]

…Problem of topological Mapping need ot be solved first.
…Problem of topological Mapping need ot be solved first.
… is filled like dynamic topo. Disable some deletion in the removeTetra2Triangle process. Will solve this problem later.
@epernod
Copy link
Contributor Author

epernod commented Jul 16, 2018

[ci-build][with-scene-tests]

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 18, 2018
@hugtalbot hugtalbot merged commit 00870a2 into sofa-framework:master Jul 19, 2018
@epernod epernod deleted the topology_tests branch July 19, 2018 14:05
@guparan guparan added this to the v18.12 milestone Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants