-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaGraphComponent] ADD alias usage detection #702
[SofaGraphComponent] ADD alias usage detection #702
Conversation
…d using an alias. There is some consensus on the fact that we should remove the hard coded alias on components. To make that possible we implemented a system to inform user they are using such an alias and that it would be wise to stop using it.
… when an alias is used.
and better log messages
Thanks @guparan for this work, I will try it. |
[ci-build] |
I have tried it in runSofa2 and it work like a charm and is actually a very useful warning (maybe we should add a line saying: "to remove this warning message you need to ...." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleaning work and new feature. Nothing to say.
if( deprecatedComponents.find( o->getClassName() ) != deprecatedComponents.end() ) | ||
{ | ||
msg_deprecated(o) << deprecatedComponents.at(o->getClassName()).getMessage(); | ||
msg_deprecated(this->getName()) << deprecatedComponents.at(o->getClassName()).getMessage(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change lead to un-readable message because the name of the component is not showned anymore.
# Conflicts: # modules/SofaGraphComponent/SceneCheckUsingAlias.h
5867de1
to
c991098
Compare
[ci-build][with-scene-tests] |
1 similar comment
[ci-build][with-scene-tests] |
This STC#5 sprint pull-request cleans the whole Scene Checking API.
It also adds a new SceneCheck that warns for alias uses:
SceneCheckUsingAlias
It's a first step concerning #677 👍
This PR:
Reviewers will merge only if all these checks are true.