[SofaGraphComponent] ADD alias usage detection #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d using an alias. There is some consensus on the fact that we should remove the hard coded alias on components. To make that possible we implemented a system to inform user they are using such an alias and that it would be wise to stop using it.
… when an alias is used.
and better log messages
guparan
added
enhancement
|
Thanks @guparan for this work, I will try it. |
|
[ci-build] |
|
I have tried it in runSofa2 and it work like a charm and is actually a very useful warning (maybe we should add a line saying: "to remove this warning message you need to ...." |
| if( deprecatedComponents.find( o->getClassName() ) != deprecatedComponents.end() ) | ||
| { | ||
| msg_deprecated(o) << deprecatedComponents.at(o->getClassName()).getMessage(); | ||
| msg_deprecated(this->getName()) << deprecatedComponents.at(o->getClassName()).getMessage(); |
There was a problem hiding this comment.
This change lead to un-readable message because the name of the component is not showned anymore.
# Conflicts: # modules/SofaGraphComponent/SceneCheckUsingAlias.h
guparan
force-pushed
the
add_alias_usage_detection
branch
from
5867de1
to
c991098
Compare
guparan
added
pr: status ready
|
[ci-build][with-scene-tests] |
1 similar comment
|
[ci-build][with-scene-tests] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This STC#5 sprint pull-request cleans the whole Scene Checking API.
It also adds a new SceneCheck that warns for alias uses:
SceneCheckUsingAliasIt's a first step concerning #677 👍
This PR:
Reviewers will merge only if all these checks are true.