-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaSparseSolver][SofaPreconditioner] modularization #668
[SofaSparseSolver][SofaPreconditioner] modularization #668
Conversation
Using code directly in the root of the a module/plugin has the dis-advantage of of leaking the .h too easily. Eg: -I"modules" or worse ("-I../") allows to include any modules that is into the directory without needs to have a corresponding find_package(SofaPreconditioner) in the CMakeLists.txt
…ory. Not because it is fun, but because it improves the packaging of the module by preventing user of the module to do "-Imodules" then #include<SofaSparseSolver/xx> without having the corresponding find_package(SofaSparseSolver) Signed-off-by: Damien Marchal <damien.marchal@univ-lille1.fr>
RENAMES in the defines - SOFA_SPARSE_SOLVER_API -> SOFA_SOFASPARSESOLVER_API - SOFA_BUILD_SPARSE_SOLVER -> SOFA_BUILD_SOFASPARSESOLVER - SOFA_HAVE_SPARSESOLVER -> SOFA_HAVE_SOFASPARSESOLVER
…r & SofaPreconditioner
… properly integrate the module.
[ci-build][with-scene-tests] |
@guparan, @hugtalbot Could we considering progressing on those...they are now wainting for review since weeks :) |
I'm on it 😉 |
…rize_SparseSolverPR
[ci-build][with-scene-tests] |
Nice work @damienmarchal, this PR is approved. |
[ci-build][with-scene-tests] |
TODO: resolve conflict then merge |
…rize_SparseSolverPR
[ci-build][with-scene-tests] |
1 similar comment
[ci-build][with-scene-tests] |
As said in the title this PR puts SofaSparseSolver and SofaPreconditioner as a real module that can be activated/deactivated.
CHANGLELOG/
This PR:
Reviewers will merge only if all these checks are true.