-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[all] Various small changes in error messages & bugfix from defrost branches #660
Merged
guparan
merged 13 commits into
sofa-framework:master
from
SofaDefrost:variousMinorChange
May 25, 2018
Merged
[all] Various small changes in error messages & bugfix from defrost branches #660
guparan
merged 13 commits into
sofa-framework:master
from
SofaDefrost:variousMinorChange
May 25, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orce. Because constraints are not only used for contact. This is purely in string & comment.
The Data should point to a valid (persistant) string buffer which I'm not sure it is returned by a stringstream to c_str().
… of the component.
NB: this #define "VERBOSE" is so ugly.
…e the object event if no ODE solver is implicitely found And disable the component & reports adequate warnings in case the solver cannot be found.
std::stringstream.str().c_str() is not allocating a memory buffer.
to avoid having this code duplicated all around.
A lot of users don't understand this message and they often consider that it is explaining the cause of their scene crashing.
hugtalbot
added
pr: fix
Fix a bug
pr: status to review
To notify reviewers to review this pull-request
labels
May 22, 2018
hugtalbot
approved these changes
May 22, 2018
[ci-build][with-scene-tests] |
hugtalbot
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Reviewers will merge only if all these checks are true.