Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all] Various small changes in error messages & bugfix from defrost branches #660

Merged
merged 13 commits into from
May 25, 2018
Merged

[all] Various small changes in error messages & bugfix from defrost branches #660

merged 13 commits into from
May 25, 2018

Conversation

damienmarchal
Copy link
Contributor

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@damienmarchal
[SofaKernel & SofaConstraint] REPLACE contact force with constraint f…
ab49917 
…orce.

Because constraints are not only used for contact.
This is purely in string & comment.
@damienmarchal
[RequiredPlugin] REPLACE msg_info("RequiredPlugin") by msg_info()
fc39bae
@damienmarchal
[SofaKernel] BUGFIX memory error in vectorData.
1e42150 
The Data should point to a valid (persistant) string buffer which I'm not
sure it is returned by a stringstream to c_str().
@damienmarchal
[SofaKernel/DefaultAnimationLoop] ADD more details to the description…
436bb83 
… of the component.
@damienmarchal
[SofaKernel/BaseData] Initialize the char* pointer to nullptr by defa…
79ae86b 
…ult.
@damienmarchal
[SofaKernel/DefaultMultMatrixAccessor] CHG Rephrase debugging comments.
90f413e 
NB: this #define "VERBOSE" is so ugly.
@damienmarchal
[SofaKernel/RestShapeSpringsForceField] CHG Rephrase the component de…
db237ca 
…scription.
@damienmarchal
[SofaConstraint/LinearSolverConstraintCorrection] CHG Allows to creat…
50fe60f 
…e the object event if no ODE solver is implicitely found

And disable the component & reports adequate warnings in case the solver cannot be found.
@damienmarchal
[SofaGeneralEngine] FIX help message in MergeMeshes.
237e68c 
std::stringstream.str().c_str() is not allocating a memory buffer.
@damienmarchal
[SofaHelper] ADD StringUtils::getAStringCopy
d861f86 
to avoid having this code duplicated all around.
@damienmarchal
Merge remote-tracking branch 'upstream/master' into variousMinorChange
fb62c87
@damienmarchal
[runSofa] CHANGE error message about invalid bounding box
8b4a19a 
A lot of users don't understand this message and they often consider that it is
explaining the cause of their scene crashing.
@damienmarchal
[runSofa] BUGFIX ISSUE sofa-framework#654 (unable to save view in rea…
5c7d54a 
…lGUI)

sofa-framework#654
@hugtalbot hugtalbot added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels May 22, 2018
@hugtalbot
Copy link
Contributor

[ci-build][with-scene-tests]

@damienmarchal damienmarchal mentioned this pull request May 22, 2018
Closed
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 23, 2018
@guparan guparan merged commit 25f2a56 into sofa-framework:master May 25, 2018
@guparan guparan added this to the v18.06 milestone Jun 18, 2018
@damienmarchal damienmarchal deleted the variousMinorChange branch August 6, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees
No one assigned
Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.06
Development

Successfully merging this pull request may close these issues.
3 participants
@damienmarchal @hugtalbot @guparan