Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MultiThreading] FIX: add createSubelements param in MeshGmshLoader #626

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Apr 9, 2018

This fix was already applied to examples/Components/forcefield/TriangularForceFieldComparison.scn
See 28c8b68

Sorry but I can't explain why this fix was needed in the first place.
If someone could, that would be great 👍


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

This fix was already applied to examples/Components/forcefield/TriangularForceFieldComparison.scn
See 28c8b68
@guparan
Copy link
Contributor Author

guparan commented Apr 9, 2018

[ci-build][with-scene-tests]

@guparan guparan added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Apr 9, 2018
@guparan
Copy link
Contributor Author

guparan commented Apr 9, 2018

[ci-build][with-scene-tests]

@epernod epernod self-requested a review April 11, 2018 08:38
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Apr 11, 2018
@epernod
Copy link
Contributor

epernod commented Apr 11, 2018

createSubelements="true": Divide all n-D elements into their (n-1)-D boundary elements (e.g. tetrahedra to triangles).
Meaning: for a triangulation, create all edges.

In this case the mesh file had only edges of the border but the FF were using all edges of the mesh.

@epernod
Copy link
Contributor

epernod commented Apr 11, 2018

This PR fix the crash.

But some work is needed on the meshloader to avoid this behavior.

@guparan guparan merged commit ee46fc3 into sofa-framework:master Apr 11, 2018
@guparan guparan deleted the fix_MultiThreading_TriangularForceFieldComparison branch April 27, 2018 07:41
@guparan guparan added this to the v18.06 milestone Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants