Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[modules] FIX data field name in VariationalSymplecticSolver #624

Merged
merged 1 commit into from
Apr 10, 2018
Merged

[modules] FIX data field name in VariationalSymplecticSolver #624

merged 1 commit into from
Apr 10, 2018

Conversation

IPeterlik
Copy link
Contributor

FIX: Name of a parameter (allowing to select incremental potential energy): before, the name contained spaces, was replaced by useIncrementalPotentialEnergy.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@IPeterlik IPeterlik added enhancement About a possible enhancement pr: fix Fix a bug labels Apr 9, 2018
@IPeterlik IPeterlik self-assigned this Apr 9, 2018
@IPeterlik IPeterlik added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed labels Apr 9, 2018
@guparan guparan added pr: status to review To notify reviewers to review this pull-request and removed pr: status ready Approved a pull-request, ready to be squashed labels Apr 10, 2018
@guparan
Copy link
Contributor

guparan commented Apr 10, 2018

[ci-build][with-scene-tests]

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Apr 10, 2018
@guparan guparan merged commit 04141c1 into sofa-framework:master Apr 10, 2018
@guparan guparan added this to the v18.06 milestone Jun 18, 2018
@pedroperrusi pedroperrusi deleted the fix_variationalSymplecticSolver branch April 16, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot Awaiting requested review from hugtalbot

@hdeling hdeling Awaiting requested review from hdeling

Assignees

@IPeterlik IPeterlik

Labels
enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.06
Development

Successfully merging this pull request may close these issues.
2 participants
@IPeterlik @guparan