[NG] MOVE SofaComponent* to packages #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more in phase with existing packages like SofaComponentAdvanced, etc.
Make a distinction between packages that are only CMake aggregators and applications/packages that are libraries.
guparan
added
project: Sofa NG
pr: status to review
Closed
|
[ci-build][with-scene-tests] |
| set(SOURCE_FILES config/${PROJECT_NAME}.cpp) | ||
|
|
||
| list(APPEND HEADER_FILES | ||
| deprecated_layout/SofaComponentBase/MakeAliasComponent.h |
There was a problem hiding this comment.
Please validate deprecated_layout principle
| ) | ||
|
|
||
| list(APPEND HEADER_FILES | ||
| src/sofa/component/utils/MakeAliasComponent.h |
There was a problem hiding this comment.
Please validate src/namespace/component principle
| @@ -1,6 +1,8 @@ | |||
| cmake_minimum_required(VERSION 3.1) | |||
| project(SofaGuiQt) | |||
|
|
|||
| find_package(Sofa.Component.Utils) | |||
There was a problem hiding this comment.
Please give feedback on "." naming convention for Sofa.component.Utils
| @@ -0,0 +1,48 @@ | |||
| /****************************************************************************** | |||
There was a problem hiding this comment.
Please validate this new way to name config.h files
guparan
added
pr: status ready
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please gently welcome this first NG pull-request 😊
The base idea was to remove the SofaComponent* packages from modules and to put them in their own place instead.
Doing this, I realized that SofaComponentBase contains actual components (it's not only a basic package as it should be).
Thus, it permitted me to introduce the first NG module Sofa.Component.Utils and fill it with SofaComponentBase intruders (MakeAliasComponent, MakeDataAliasComponent, MessageHandlerComponent, InfoComponent).
NG architecture is based on the discussions in #543.
Transition headers are also provided (in deprecated_layout folder) to ensure old includes.
I am also working with @damienmarchal on a way to cleanly automatize this kind of NG refactoring with python: see https://github.com/guparan/sofa2ng
Feedback is more than welcome!
This PR:
Reviewers will merge only if all these checks are true.