Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaFramework] FIX Boost::program_options finding in install #618

Merged
merged 1 commit into from
Apr 3, 2018
Merged

[SofaFramework] FIX Boost::program_options finding in install #618

merged 1 commit into from
Apr 3, 2018

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Mar 27, 2018 •
edited
Loading

This PR fixes install finding of Boost::program_options dependency added for the new ArgumentParser API in #513

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@guparan guparan added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request pr: backport done This PR has been backported into the release before its milestone. labels Mar 27, 2018
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 28, 2018
@hugtalbot hugtalbot merged commit 969a290 into sofa-framework:master Apr 3, 2018
@guparan guparan added this to the v17.12 milestone Apr 5, 2018
guparan added a commit that referenced this pull request Apr 5, 2018
@guparan
[Changelog] Backport #618
f232742
guparan pushed a commit that referenced this pull request Apr 5, 2018
@hugtalbot @guparan
Merge pull request #618 from guparan/fix_findboost_install
81523e5 
[SofaFramework] FIX Boost::program_options finding in install
guparan added a commit that referenced this pull request Apr 5, 2018
@guparan
[Changelog] Backport #618
ff69857
@guparan guparan deleted the fix_findboost_install branch April 27, 2018 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: backport done This PR has been backported into the release before its milestone. pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.
2 participants
@guparan @hugtalbot