Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Headless Recorder] ADD frameskip option to headless recorder #615

Merged

Conversation

tgaugry
Copy link
Contributor

@tgaugry tgaugry commented Mar 21, 2018

This PR add a frameskip option to the headless recorder.
Previous behavior is kept for compatibility.
Frameskip option can have 4 different values :

  • noskip and simulationtime : previous behavior, now default. One frame is taken at each time step.
  • realtime : Output images at rate of 1/fps
  • an arbitrary float : tries to skip this much time between each frame.

The order between simulation and frame saving has also been inverted : now the first frame taken is at time 0, instead of time dt.


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@guparan guparan added enhancement About a possible enhancement location: plugins pr: status to review To notify reviewers to review this pull-request labels Mar 26, 2018
@damienmarchal
Copy link
Contributor

Rajouter un prefix pour donner l'unité ?
--frameinterval 5.0ms (
--frameinterval 1/60hz (real time)
--frameinterval no (simulation time)

@damienmarchal
Copy link
Contributor

damienmarchal commented Mar 28, 2018

--recordingtime wallclocktime
--recordingtime simulationtime
--recordingtime timeinterval=5ms

Ou
--recordingmode wallclocktime
--recordingmode simulationtime
--recordingmode fixedtimeinterval=5ms

@tgaugry
Copy link
Contributor Author

tgaugry commented Mar 28, 2018

Le commit oublié a été rajouté

@guparan guparan added pr: status wip Development in the pull-request is still in progress pr: status to review To notify reviewers to review this pull-request and removed pr: status to review To notify reviewers to review this pull-request pr: status wip Development in the pull-request is still in progress labels Mar 28, 2018
@hugtalbot
Copy link
Contributor

@tgaugry ok seems good ! could you just (as a final minor remark) add as an explanation on the meaning of the three options RecordMode and their significations: wallclocktime, simulationtime, timeinterval, in HeadlessRecorder.h ligne 67
then we merge !

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Apr 9, 2018
@guparan guparan merged commit ff3b60e into sofa-framework:master Apr 10, 2018
@tgaugry tgaugry deleted the thga-headless-recorder-frameskip branch May 4, 2018 07:30
@guparan guparan added this to the v18.06 milestone Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants