-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Headless Recorder] ADD frameskip option to headless recorder #615
[Headless Recorder] ADD frameskip option to headless recorder #615
Conversation
Rajouter un prefix pour donner l'unité ? |
--recordingtime wallclocktime Ou |
Le commit oublié a été rajouté |
@tgaugry ok seems good ! could you just (as a final minor remark) add as an explanation on the meaning of the three options RecordMode and their significations: wallclocktime, simulationtime, timeinterval, in HeadlessRecorder.h ligne 67 |
…e the very first frame was ignored
This PR add a frameskip option to the headless recorder.
Previous behavior is kept for compatibility.
Frameskip option can have 4 different values :
The order between simulation and frame saving has also been inverted : now the first frame taken is at time 0, instead of time dt.
This PR:
Reviewers will merge only if all these checks are true.