-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CImgPlugin] FIX CMakeLists install fail since pluginization #609
[CImgPlugin] FIX CMakeLists install fail since pluginization #609
Conversation
Even in the eventuality that more changes are needed to actually clean the installation of SOFA, these changes still are needed. |
Hi all, Thank bruno for the PR. @guparan I'm not sure we should merge this now. Having a .in means that the file is a template that is transformed by CMakeLists. This is not the case here so the .in file is misleading and useless. In case we prefer an autogenerated config.h.in from a template it would be much better to have a single one instead of one per plugin/module. /// This file is autogenerated by CMakeLists.txt please do not edit.
#ifndef @PROJECT_CNAME@_CONFIG_H
#define @PROJECT_CNAME@_CONFIG_H
#include <SofaBase/config.h>
#ifdef SOFA_BUILD_@PROJECT_CNAME@
# define SOFA_TARGET @PROJECT_NAME@
# define SOFA_@PROJECT_CNAME@_API SOFA_EXPORT_DYNAMIC_LIBRARY
#else
# define SOFA_@PROJECT_CNAME@_API SOFA_IMPORT_DYNAMIC_LIBRARY
#endif
#endif /// @PROJECT_CNAME@_CONFIG_H |
[ci-build][with-scene-tests] |
Hello,
Since we talked about it during the SofaDev meeting,
Here's our QuickNDirty answer to the make install fail for CImgPlugin.
Of course as-is it is not acceptable or mergeable but it's here
This PR:
Reviewers will merge only if all these checks are true.