[SofaGUI] Move GlutGUI to projects and remove all glut references in SofaFramework #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
changed the title
hugtalbot
added
the
pr: status to review
|
[ci-build][with-scene-tests] |
guparan
reviewed
Feb 26, 2018
applications/projects/CMakeLists.txt
Outdated
| ## Glut GUI | ||
| find_package(GLUT) | ||
| if(GLUT_FOUND) | ||
| sofa_add_application(SofaPhysicsAPI SofaPhysicsAPI) |
There was a problem hiding this comment.
Would be better to add every app disabled and let them fail when running find_package(GLUT REQUIRED) if enabled, no?
I don't think this CMakeLists should be smartly checking GLUT_FOUND. It's not its dependency.
There was a problem hiding this comment.
I was wondering the same, but I was lazy to add the check in all the projects needing glut.
But I guess you are right so I will add it in those projects directly
guparan
added
pr: status ready
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glut is a deprecated library and in my opinion, should be not used anymore. (not compatible with newer version of OpenGL, etc)
It can be replaced with GLFW to create quick graphical applications.
This first PR is moving the SofaGuiGlut to the applications directory, in case any people are still using it.
Actually, the code was not compatible with the current SofaGui API and was not compiling.
The code is now compilable and launchable anyway.
Any reference to Glut are removed from the SofaFramework (header, CMake) and from runSofa.
Lastly, a replacement using gflw will be pushed in the near future, for people wishing to have a simple GUI without the heavy-duty Qt Framework.
This PR:
Reviewers will merge only if all these checks are true.