-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaGUI] Move GlutGUI to projects and remove all glut references in SofaFramework #598
Conversation
[ci-build][with-scene-tests] |
applications/projects/CMakeLists.txt
Outdated
## Glut GUI | ||
find_package(GLUT) | ||
if(GLUT_FOUND) | ||
sofa_add_application(SofaPhysicsAPI SofaPhysicsAPI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better to add every app disabled and let them fail when running find_package(GLUT REQUIRED)
if enabled, no?
I don't think this CMakeLists should be smartly checking GLUT_FOUND
. It's not its dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering the same, but I was lazy to add the check in all the projects needing glut.
But I guess you are right so I will add it in those projects directly
Glut is a deprecated library and in my opinion, should be not used anymore. (not compatible with newer version of OpenGL, etc)
It can be replaced with GLFW to create quick graphical applications.
This first PR is moving the SofaGuiGlut to the applications directory, in case any people are still using it.
Actually, the code was not compatible with the current SofaGui API and was not compiling.
The code is now compilable and launchable anyway.
Any reference to Glut are removed from the SofaFramework (header, CMake) and from runSofa.
Lastly, a replacement using gflw will be pushed in the near future, for people wishing to have a simple GUI without the heavy-duty Qt Framework.
This PR:
Reviewers will merge only if all these checks are true.