Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaDistanceGrid] ADD .scene-tests to ignore scene #594

Merged
merged 1 commit into from
Mar 1, 2018
Merged

[SofaDistanceGrid] ADD .scene-tests to ignore scene #594

merged 1 commit into from
Mar 1, 2018

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Feb 19, 2018 •
edited
Loading

ignored scene: DistanceGridForceField-liver.scn

This way, the scene has to remain ignored to build the plugin in default mode (we need it for SofaImplicitField, which is needed for a bunch of examples).

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@guparan guparan added location: plugins pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Feb 19, 2018
@guparan
[SofaDistanceGrid] ADD .scene-tests to ignore scene
7b16e99 
ignored scene: DistanceGridForceField-liver.scn
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 26, 2018
@damienmarchal damienmarchal merged commit 2462c9c into sofa-framework:master Mar 1, 2018
@guparan guparan added this to the v18.06 milestone Apr 5, 2018
@guparan guparan deleted the ci_ignore_distancegrid_scene branch April 27, 2018 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.06
Development

Successfully merging this pull request may close these issues.
2 participants
@guparan @damienmarchal