Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOOLS] FIX sofa-launcher stdout #592

Merged
merged 1 commit into from
Feb 21, 2018

Conversation

VannesteFelix
Copy link
Contributor

@VannesteFelix VannesteFelix commented Feb 15, 2018

This PR fix an issue with sofa-launcher.

When we are using sofa-launcher the scene we want to execute is copied in the /tmp directory.
But because we weren't closing the current file it wasn't saved and so wasn't executed.

The fix close it.


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@sofabot
Copy link
Collaborator

sofabot commented Feb 15, 2018

Thank you for your pull request!
Someone will soon check it and start the builds.

Note that by submitting a contribution to SOFA, you hereby accept and agree to the terms and conditions detailed in the associated CLA

@hugtalbot
Copy link
Contributor

[ci-build][with-scene-tests]

@hugtalbot hugtalbot added enhancement About a possible enhancement project: CI labels Feb 15, 2018
@damienmarchal
Copy link
Contributor

damienmarchal commented Feb 15, 2018

+1 for this PR.

That also fix problem with the parallel launcher.

Copy link
Contributor

@damienmarchal damienmarchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve :)

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 18, 2018
@guparan guparan merged commit a48a9d5 into sofa-framework:master Feb 21, 2018
@guparan guparan added this to the v18.06 milestone Apr 5, 2018
@damienmarchal damienmarchal deleted the sofa-launcher branch December 17, 2018 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants