Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaMiscFem, SofaSimulationGraph] FIX dependencies #588

Merged
merged 2 commits into from
Feb 15, 2018
Merged

[SofaMiscFem, SofaSimulationGraph] FIX dependencies #588

merged 2 commits into from
Feb 15, 2018

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Feb 12, 2018 •
edited
Loading

Small PR to fix two unneeded dependencies :-)

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@guparan guparan added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Feb 12, 2018
@guparan guparan changed the title Fix dependencies [SofaMiscFem, SofaSimulationGraph] FIX dependencies Feb 12, 2018
damienmarchal
damienmarchal approved these changes Feb 12, 2018
View reviewed changes
Copy link
Contributor

@damienmarchal damienmarchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 14, 2018
@hugtalbot hugtalbot merged commit 465237c into sofa-framework:master Feb 15, 2018
@guparan guparan deleted the fix_dependencies branch February 19, 2018 08:51
@guparan guparan restored the fix_dependencies branch February 19, 2018 08:51
@guparan guparan added this to the v18.06 milestone Apr 5, 2018
@guparan guparan deleted the fix_dependencies branch April 27, 2018 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienmarchal damienmarchal damienmarchal approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.06
Development

Successfully merging this pull request may close these issues.
3 participants
@guparan @damienmarchal @hugtalbot