-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaLoader] ADD support to load VTK polylines in legacy formated files #576
Conversation
[ci-build][with-scene-tests] |
@untereiner thanks for the PR, could you please point us out the lines that you really (not format changes) modified ? |
there are several lines at several places.... a bit shitting to put them here... search for Polyline |
MeshLoader.cpp (ligne 690) |
What astyle command did you launch to get this diff? |
My bad, I shouldn't trust GitHub blindly. |
@@ -527,6 +532,7 @@ bool MeshVTKLoader::setInputsMesh() | |||
delete reader->inputCellTypes; | |||
} | |||
|
|||
d_polygons.endEdit(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean d_polylines
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, I'll change it
This PR:
Reviewers will merge only if all these checks are true.