Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaGraphComponent] FIX SceneChecker & RequiredPlugin #563

Merged
merged 2 commits into from
Jan 18, 2018
Merged

[SofaGraphComponent] FIX SceneChecker & RequiredPlugin #563

merged 2 commits into from
Jan 18, 2018

Conversation

damienmarchal
Copy link
Contributor

@damienmarchal damienmarchal commented Jan 17, 2018 •
edited by guparan
Loading

This PR Do:
[SofaGraphComponent] FIX Bug in scene checker.
[SofaGraphComponent] FIX RequiredPlugin

For more details have a look at the commit messages.
This PR is a re-split of PR #548 to ease review & merging.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@damienmarchal
[SofaGraphComponent] FIX Bug in scene checker.
9539052 
This PR does:
 - The scene checkers now emit much less warning (one per warning type per run)
@damienmarchal
[SofaGraphComponent] FIX RequiredPlugin
07b06a2 
The plugins was allowing either to provide the plugin to load
in the component's name or in the pluginName attributes. To increase the
consistency if the plugin to load is provided in the name attribute then
the 'name' is copied in the pluginName lists.

So that code using RequiredPlugin knows that the list of plugins are in
pluginName.
@damienmarchal damienmarchal changed the title Fix scenechecker1712 [SofaGraphComponent] FIX SceneChecker & RequiredPlugin Jan 17, 2018
@damienmarchal
Copy link
Contributor Author

[ci-build][with-scene-tests]

@damienmarchal damienmarchal added pr: fix Fix a bug pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Jan 18, 2018
@damienmarchal damienmarchal added this to the v17.12 milestone Jan 18, 2018
@damienmarchal
Copy link
Contributor Author

Same here, I have done the split of #548
Please review quickly & merge if OK for 17.12.
@guparan @hugtalbot @fredroy @bruno-marques @bcarrez

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 18, 2018
@guparan guparan merged commit 1eb77ed into sofa-framework:master Jan 18, 2018
@guparan guparan changed the title [SofaGraphComponent] FIX SceneChecker & RequiredPlugin [SofaGraphComponent] FIX SceneChecker & RequiredPlugin Jan 25, 2018
@damienmarchal damienmarchal deleted the fixScenechecker1712 branch February 12, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.
2 participants
@damienmarchal @guparan