Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CImgPlugin] Use sofa cmake command to create proper package #544

Merged
merged 1 commit into from
Dec 19, 2017

Conversation

thomas-lemaire
Copy link
Contributor

@thomas-lemaire thomas-lemaire commented Dec 14, 2017

With this PR you can find_package(CImgPlugin) in an other cmake project. Quite useful since this plugin is indeed part of the core


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@damienmarchal
Copy link
Contributor

damienmarchal commented Dec 14, 2017

+1

To CmakeLists.txt guys,

just a small question I have

  • what is this for ?
    if(NOT TARGET CImgPlugin)
    include("${CMAKE_CURRENT_LIST_DIR}/CImgPluginTargets.cmake")
    endif()

  • shouldn't we also export something like
    CImgPlugin_INCLUDE_DIR ?

To make the plugin relocatable ?

@damienmarchal damienmarchal changed the title Use sofa cmake command to create proper package [CImgPlugin] Use sofa cmake command to create proper package Dec 14, 2017
@guparan guparan added pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed labels Dec 19, 2017
@guparan
Copy link
Contributor

guparan commented Dec 19, 2017

I need these changes for v17.12 so I fast-merge them.

@damienmarchal : @fredroy should know the answer to your questions.

@guparan guparan merged commit 1a3f4e2 into sofa-framework:master Dec 19, 2017
@guparan guparan added this to the v17.12 milestone Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants