Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Helper] Fix memory leak while capturing screenshot #533

Merged
merged 1 commit into from
Dec 11, 2017
Merged

[Helper] Fix memory leak while capturing screenshot #533

merged 1 commit into from
Dec 11, 2017

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Nov 30, 2017 •
edited
Loading

Capture::saveScreenshot was not destroying the content of the Image pointer.
This solves this, plus adds one check on the pointer and add message output.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@fredroy fredroy added issue: bug (major) Critical bug affecting everyone: not working, performances or accuracy degraded pr: fast merge Minor change that can be merged without waiting for the 7 review days labels Nov 30, 2017
@damienmarchal damienmarchal added the pr: status to review To notify reviewers to review this pull-request label Nov 30, 2017
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 6, 2017
@guparan guparan added pr: fix Fix a bug and removed issue: bug (major) Critical bug affecting everyone: not working, performances or accuracy degraded labels Dec 11, 2017
@guparan guparan merged commit ffc9de0 into sofa-framework:master Dec 11, 2017
@guparan guparan added this to the v17.12 milestone Dec 14, 2017
@fredroy fredroy deleted the fix_memleak_screenshot branch May 13, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.
3 participants
@fredroy @guparan @damienmarchal