Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix VariationalSymplecticImplicitSolverNonLinearForceDynamic_test #478

Merged
merged 1 commit into from
Oct 18, 2017
Merged

fix VariationalSymplecticImplicitSolverNonLinearForceDynamic_test #478

merged 1 commit into from
Oct 18, 2017

Conversation

bcarrez
Copy link
Contributor

@bcarrez bcarrez commented Oct 16, 2017 •
edited by guparan
Loading

As this test needs LennardJonesFF, which is now deprecated, the test has been deprecated to fix this. It now runs smoothly in "full" component set and is removed from "standard".

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@bcarrez bcarrez added location: tests pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug labels Oct 16, 2017
@damienmarchal
Copy link
Contributor

It is the return of green in our dashboard... Bruno is the hero of the day !

@hugtalbot hugtalbot added the pr: status to review To notify reviewers to review this pull-request label Oct 16, 2017
@damienmarchal
Copy link
Contributor

We want green dashboard :)

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 17, 2017
@hugtalbot hugtalbot merged commit a759d27 into sofa-framework:master Oct 18, 2017
@hugtalbot
Copy link
Contributor

Green dashboard ... hold your breath !

@damienmarchal
Copy link
Contributor

Roadmap for a totally green dashboard:

  • fix the last centos bug (I heard about bruno started digging into this one)
  • fix the 14 ubuntu_options_debug (I made [SofaKernel] Add automatically the "_d" suffix when loading plugins in debug #465 that fix it but @fjourdes pointed that one of the pending InSimo PR was doing that in a more powerful/general way...so ...I praise that someone will nudge the InSimo and merge it :))
  • fix the windows (well these are my fault...so I will have to spend time on that)

But after that...well happy.

@bcarrez bcarrez deleted the deprecate_elacticitytest_createSunPlanetSystem branch October 20, 2017 14:35
@guparan guparan added this to the v17.12 milestone Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.
4 participants
@bcarrez @damienmarchal @hugtalbot @guparan