Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build] FIX Sofa installation failure (tries to install non-existing files) #470

Merged
merged 1 commit into from
Oct 13, 2017
Merged

[Build] FIX Sofa installation failure (tries to install non-existing files) #470

merged 1 commit into from
Oct 13, 2017

Conversation

vmagno
Copy link
Contributor

@vmagno vmagno commented Oct 12, 2017 •
edited by jnbrunet
Loading

A directory that was recently removed is still mentioned in the cmake build files, so installation fails (compilation is fine).

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@vmagno vmagno added the pr: fix Fix a bug label Oct 12, 2017
@hugtalbot hugtalbot added the pr: status to review To notify reviewers to review this pull-request label Oct 12, 2017
@vmagno vmagno requested a review from jnbrunet October 13, 2017 11:46
@jnbrunet jnbrunet added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Oct 13, 2017
@jnbrunet
Copy link
Contributor

The files were removed by commit d481010

@jnbrunet jnbrunet merged commit dbd0bef into sofa-framework:master Oct 13, 2017
@jnbrunet jnbrunet deleted the fix_sofa_install_failure branch October 13, 2017 11:58
@guparan guparan added this to the v17.12 milestone Dec 14, 2017
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnbrunet jnbrunet jnbrunet approved these changes

@guparan guparan Awaiting requested review from guparan

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.
4 participants
@vmagno @jnbrunet @guparan @hugtalbot