Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaPython] FIX crash in python script when visualizing advanced timer output #458

Merged

Conversation

vmagno
Copy link
Contributor

@vmagno vmagno commented Oct 9, 2017

That script is used to parse the output of the AdvancedTimer in a Python scene to plot it. One of the function bindings has changed name, but this change was not reflected in the script.


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@sofabot
Copy link
Collaborator

sofabot commented Oct 9, 2017

Thank you for your pull request!
Someone will soon check it and start the builds.

@guparan guparan added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed labels Oct 9, 2017
@guparan
Copy link
Contributor

guparan commented Oct 9, 2017

Thank for the fix @vmagno. I directly tag it as ready.

@damienmarchal damienmarchal merged commit 885ccdd into sofa-framework:master Oct 12, 2017
@untereiner untereiner deleted the fix_AdvancedTimerOutputError branch November 8, 2017 11:08
@guparan guparan added this to the v17.12 milestone Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants