Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warning removal #454

Merged
merged 3 commits into from
Nov 2, 2017
Merged

warning removal #454

merged 3 commits into from
Nov 2, 2017

Conversation

MarkusWalzth
Copy link

@MarkusWalzth MarkusWalzth commented Oct 6, 2017 •
edited by damienmarchal
Loading

This PR will remove various warnings generated when compiling with gcc 6.3.0. Warnings coming from extlibs are not fixed.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@sofabot
Copy link
Collaborator

sofabot commented Oct 6, 2017

Thank you for your pull request!
Someone will soon check it and start the builds.

@guparan
Copy link
Contributor

guparan commented Oct 6, 2017

Thanks @MarkusWalzth !
[ci-build]

@guparan guparan added the pr: clean Cleaning the code label Oct 8, 2017
@hugtalbot hugtalbot added the pr: status to review To notify reviewers to review this pull-request label Oct 12, 2017
@damienmarchal
Copy link
Contributor

[ci-build]

@guparan guparan added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Oct 18, 2017
@guparan
Copy link
Contributor

guparan commented Oct 31, 2017

[ci-build]

@guparan guparan added pr: status to review To notify reviewers to review this pull-request pr: status ready Approved a pull-request, ready to be squashed and removed pr: status wip Development in the pull-request is still in progress pr: status to review To notify reviewers to review this pull-request labels Oct 31, 2017
@guparan guparan merged commit 97bf4a6 into sofa-framework:master Nov 2, 2017
@guparan guparan added this to the v17.12 milestone Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.
6 participants
@MarkusWalzth @sofabot @guparan @damienmarchal @hugtalbot @markuswalzthoeni