Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaCore] Add some read/write free method to construct Data Read/WriteAccessor #450

Merged
merged 1 commit into from
Oct 18, 2017

Conversation

fjourdes
Copy link
Contributor

@fjourdes fjourdes commented Oct 6, 2017

This PR adds some read/write access method for Data which can shorten slightly the syntax
required when you want to construct a Read(Write)Accessor object for a Data.
It extends the method implemented in commit 77ca6f2
for WriteOnlyAccessor to other types of Data Accessor.


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

…or objects for a given data. With c++11 an onwards it allows to use a more compact syntax to access/modify the value inside a data. Example :

auto read_data = read( object->data );

(cherry picked from commit 515996aa0278d0b6efcd22f58ac237aee754658c)
@fjourdes fjourdes changed the title Add some read/write free method to construct Data Read/WriteAccessor [SofaCore] Add some read/write free method to construct Data Read/WriteAccessor Oct 6, 2017
@guparan guparan added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Oct 10, 2017
@damienmarchal
Copy link
Contributor

I like any PR that make the SOFA API more concise and thus elegant. So +1

@guparan guparan merged commit 3d6bab5 into sofa-framework:master Oct 18, 2017
@guparan guparan added this to the v17.12 milestone Dec 14, 2017
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants