Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sofa.Testing] Do not build Sofa.Testing if SOFA_BUILD_TESTS is OFF #4459

Conversation

olivier-roussel
Copy link
Contributor

... unless there is a good reason to keep built even if tests are not built ?
In the case we have to keep it built, we will have to handle the embedded dependency google test (linked dynamically), probably in a similar manner than other libs such as metis (find package or fetch code and link dynamically).


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@olivier-roussel olivier-roussel added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code pr: backport todo This PR will be backported into the release preceeding its milestone. labels Jan 25, 2024
Copy link
Contributor

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense. In a similar manner, the .Testing modules in Sofa.Component also depend on the variable SOFA_BUILD_TESTS:

In Sofa/Component/Engine/CMakeLists.txt:

if(SOFA_BUILD_TESTS)
    add_subdirectory(Testing)
endif()

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 31, 2024
@olivier-roussel
Copy link
Contributor Author

As we just discussed, let's wait if #4471 is fine, in which case this PR should be closed and discarded: we would keep building Sofa.Testing component even if TU are not built (SOFA_BUILD_TESTS=OFF)

@olivier-roussel olivier-roussel added pr: status wip Development in the pull-request is still in progress and removed pr: status ready Approved a pull-request, ready to be squashed labels Jan 31, 2024
@bakpaul bakpaul added this to the v23.12 milestone Feb 20, 2024
@bakpaul bakpaul removed pr: status wip Development in the pull-request is still in progress pr: clean Cleaning the code pr: backport todo This PR will be backported into the release preceeding its milestone. labels Feb 20, 2024
@hugtalbot hugtalbot reopened this Feb 22, 2024
@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code pr: dev meeting topic PR to be discussed in sofa-dev meeting labels Feb 22, 2024
@olivier-roussel
Copy link
Contributor Author

olivier-roussel commented Feb 26, 2024

Any reason to have re-opened this ? I thought we all agreed that this PR would be discarded and closed as the initial behavior of having Sofa.Testing built for other plugins TU is OK and the problem with conda was fixed thanks to #447.

@hugtalbot
Copy link
Contributor

Note meeting 28/02/2024 : Sofa.Testing should externalized in order to bring real modularization

@hugtalbot hugtalbot removed the pr: dev meeting topic PR to be discussed in sofa-dev meeting label Feb 28, 2024
@hugtalbot hugtalbot closed this Feb 28, 2024
@hugtalbot hugtalbot removed the pr: status to review To notify reviewers to review this pull-request label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants