Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] fixes 401 : Correct CMake include_directories directive for SofaDefaultType target's #403

Merged
merged 1 commit into from
Sep 18, 2017
Merged

[SofaKernel] fixes 401 : Correct CMake include_directories directive for SofaDefaultType target's #403

merged 1 commit into from
Sep 18, 2017

Conversation

jnbrunet
Copy link
Contributor

@jnbrunet jnbrunet commented Sep 14, 2017 •
edited
Loading

This PR should fix #401 bug.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@jnbrunet jnbrunet added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Sep 14, 2017
@guparan guparan added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Sep 18, 2017
@jnbrunet jnbrunet merged commit e335b76 into sofa-framework:master Sep 18, 2017
@jnbrunet jnbrunet deleted the 401_wrong_cmake_directive branch September 18, 2017 19:05
@guparan guparan added this to the v17.12 milestone Dec 14, 2017
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan approved these changes

Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.

Wrong cmake directive for the SofaDefaultType target
3 participants
@jnbrunet @guparan @hugtalbot