Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] mute extlibs warnings #397

Merged
merged 2 commits into from
Sep 26, 2017
Merged

[SofaKernel] mute extlibs warnings #397

merged 2 commits into from
Sep 26, 2017

Conversation

untereiner
Copy link

@untereiner untereiner commented Sep 14, 2017 •
edited by guparan
Loading

e.g. Eigen among others

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@hugtalbot hugtalbot added the pr: status to review To notify reviewers to review this pull-request label Sep 14, 2017
@hugtalbot hugtalbot changed the title mute the warnings of sofaFramework dependencies (e.g Eigen among others) [SofaKernel] mute the warnings of sofaFramework dependencies (e.g Eigen among others) Sep 14, 2017
@untereiner
Copy link
Author

[ci-build]

@guparan guparan added the pr: clean Cleaning the code label Sep 18, 2017
@guparan guparan changed the title [SofaKernel] mute the warnings of sofaFramework dependencies (e.g Eigen among others) [SofaKernel] mute extlibs warnings Sep 18, 2017
@guparan
Copy link
Contributor

guparan commented Sep 20, 2017 •
edited
Loading

Warning (from SOFA-dev meeting): CMAKE_CURRENT_BINARY_DIR should be removed from SOFAFRAMEWORK_DEPENDENCY_INCLUDE_DIRECTORIES

@guparan guparan added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Sep 20, 2017
@untereiner
Copy link
Author

untereiner commented Sep 21, 2017 •
edited
Loading

If I am not wrong the only difference is that it mutes the warnings of CImg and gtest with the CMAKE_CURRENT_BINARY_DIR variable in SOFAFRAMEWORK_DEPENDENCY_INCLUDE_DIRECTORIES. Why should I drop it ?

@guparan
Copy link
Contributor

guparan commented Sep 25, 2017

In this context CMAKE_CURRENT_BINARY_DIR = <bin_dir>/SofaKernel/SofaFramework.
Why do we need to add <bin_dir>/SofaKernel/SofaFramework as include directory?
Sorry to answer your question with another question 😕

@untereiner
Copy link
Author

untereiner commented Sep 26, 2017 •
edited
Loading

Maybe someone should clean all these messy CMakelists ... a task for Sofa NG ? (a new question 😄 )

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status wip Development in the pull-request is still in progress labels Sep 26, 2017
@guparan guparan merged commit e4f9e3d into sofa-framework:master Sep 26, 2017
@untereiner untereiner deleted the fix_warnings branch September 26, 2017 15:41
@guparan guparan added this to the v17.12 milestone Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.
3 participants
@untereiner @guparan @hugtalbot