Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SofaBaseTopology] FIX wrong clean in PointSetTopologyModifier #380

Merged
merged 2 commits into from
Aug 31, 2017

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Aug 30, 2017

Quick commit to fix build error after #370 merge.


This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@guparan guparan added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug labels Aug 30, 2017
@damienmarchal
Copy link
Contributor

damienmarchal commented Aug 30, 2017

Thank you Guillaume,
I vote for fast-merge.

But i think it is better to chain the two message like that:

msg_info() << "Blahblah" << msgendl
                  << "Other thing";

Because it faster and if the two line are forming a single message it is more clear to have that:

INFO (MyComponent) : "Blahblah" 
                                       "OtherThing"

Instead of:

INFO (MyComponent) : "Blahblah"
INFO (MyComponent) : "OtherThing"

Copy link
Contributor

@damienmarchal damienmarchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok...but I think it is better to chaing the two message in a single dmsg_info(). I give an example in the comments.

@guparan
Copy link
Contributor Author

guparan commented Aug 30, 2017

Agree, was just missing msgendl existence ;-)

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Aug 31, 2017
@hugtalbot hugtalbot merged commit f42902b into sofa-framework:master Aug 31, 2017
@guparan guparan modified the milestones: v17.06, v17.12 Sep 13, 2017
@guparan guparan deleted the fix_ostream_error branch February 19, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants