[all] Fix warnings and strange double incrementation on iterator #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 10, 2017 11:13
This looks really strange, double incrementation. Should be reviewed
hugtalbot
requested review from
fredroy,
courtecuisse and
ChristianDuriez
and removed request for
fredroy
hugtalbot
added
the
pr: status to review
| @@ -954,10 +954,8 @@ void projection(LCP &fineLevel, LCP &coarseLevel, int nbContactsCoarse, const st | |||
| /// all parameters as input | |||
| /// output=> change value of F in fineLevel | |||
|
|
|||
| void prolongation(LCP &fineLevel, LCP &coarseLevel, const std::vector<int> &projectionTable, const std::vector<int> &projectionConstraints, std::vector<double> & projectionValues, std::vector<bool> &contact_is_projected, bool verbose) | |||
|
|
|||
| void prolongation(LCP &fineLevel, LCP &coarseLevel, const std::vector<int> &projectionTable, const std::vector<int> &projectionConstraints, std::vector<double> & projectionValues, std::vector<bool> &contact_is_projected, bool /*verbose*/) | |||
There was a problem hiding this comment.
I suggest using SOFA_UNUSED instead of commenting the function signature.
There was a problem hiding this comment.
thanks @damienmarchal , correct the PR I will
|
Above @damienmarchal 's comment, this PR needs an overview regarding the code of the DefaultMultiMatrixAccessor |
hugtalbot
added
pr: status ready
|
[ci-build] |
matthieu-nesme
added a commit
to Anatoscope/sofa
that referenced
this pull request
Sep 6, 2017
[all] Fix warnings and strange double incrementation on iterator (cherry picked from commit 893c3d3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor warnings and ...
FIX strange double incrementation on iterator in DefaultMultiMatrixAccessor.cpp : @ChristianDuriez @courtecuisse your review would be great !
This PR:
Reviewers will merge only if all these checks are true.