-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[all] Fix warnings and strange double incrementation on iterator #364
[all] Fix warnings and strange double incrementation on iterator #364
Conversation
This looks really strange, double incrementation. Should be reviewed
@@ -954,10 +954,8 @@ void projection(LCP &fineLevel, LCP &coarseLevel, int nbContactsCoarse, const st | |||
/// all parameters as input | |||
/// output=> change value of F in fineLevel | |||
|
|||
void prolongation(LCP &fineLevel, LCP &coarseLevel, const std::vector<int> &projectionTable, const std::vector<int> &projectionConstraints, std::vector<double> & projectionValues, std::vector<bool> &contact_is_projected, bool verbose) | |||
|
|||
void prolongation(LCP &fineLevel, LCP &coarseLevel, const std::vector<int> &projectionTable, const std::vector<int> &projectionConstraints, std::vector<double> & projectionValues, std::vector<bool> &contact_is_projected, bool /*verbose*/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest using SOFA_UNUSED instead of commenting the function signature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @damienmarchal , correct the PR I will
Above @damienmarchal 's comment, this PR needs an overview regarding the code of the DefaultMultiMatrixAccessor |
[ci-build] |
[all] Fix warnings and strange double incrementation on iterator (cherry picked from commit 893c3d3)
Some minor warnings and ...
FIX strange double incrementation on iterator in DefaultMultiMatrixAccessor.cpp : @ChristianDuriez @courtecuisse your review would be great !
This PR:
Reviewers will merge only if all these checks are true.