Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaFramework] FIX: compilation warnings #361

Merged
merged 6 commits into from
Aug 9, 2017
Merged

[SofaFramework] FIX: compilation warnings #361

merged 6 commits into from
Aug 9, 2017

Conversation

marques-bruno
Copy link
Member

@marques-bruno marques-bruno commented Aug 8, 2017 •
edited by hugtalbot
Loading

@courtecuisse removed some compilation warnings from sofa

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@marques-bruno marques-bruno added the pr: clean Cleaning the code label Aug 8, 2017
@marques-bruno marques-bruno changed the title Fix compilation warnings [SofaFramework] FIX: compilation warnings Aug 8, 2017
@hugtalbot hugtalbot added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Aug 9, 2017
@hugtalbot hugtalbot self-requested a review August 9, 2017 08:03
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Aug 9, 2017
@hugtalbot hugtalbot merged commit 5a952b3 into sofa-framework:master Aug 9, 2017
matthieu-nesme pushed a commit to Anatoscope/sofa that referenced this pull request Aug 16, 2017
@matthieu-nesme
Merge pull request sofa-framework#361 from mimesis-inria/fix_warnings
d9abebd 
[SofaFramework] FIX: compilation warnings
(cherry picked from commit 5a952b3)
@guparan guparan modified the milestones: v17.06, v17.12 Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugtalbot hugtalbot hugtalbot approved these changes

@fredroy fredroy Awaiting requested review from fredroy

@damienmarchal damienmarchal Awaiting requested review from damienmarchal

Assignees

@courtecuisse courtecuisse

Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.
5 participants
@marques-bruno @hugtalbot @guparan @courtecuisse @SofaFramework