Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Registration] Remove ICPRegistration_ShapeMatching.scn from examples in Registration [ci-ignore] #331

Merged
merged 1 commit into from
Jul 19, 2017
Merged

[Registration] Remove ICPRegistration_ShapeMatching.scn from examples in Registration [ci-ignore] #331

merged 1 commit into from
Jul 19, 2017

Conversation

hugtalbot
Copy link
Contributor

This scene makes no sense since no ShapeMatchingForcefield is existing
in SOFA public. Another scene already shows ShapeMatching example
using the ShapeMatching engine:
ICPRegistration_ShapeMatching_Engine.scn

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

Remove ICPRegistration_ShapeMatching.scn from examples in Registration
1b35ab6 
This scene makes no sense since no ShapeMatchingForcefield is existing
in SOFA public. Another scene already shows ShapeMatching example
using the ShapeMatching engine:
ICPRegistration_ShapeMatching_Engine.scn
@hugtalbot hugtalbot added location: plugins pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days labels Jul 13, 2017
@hugtalbot hugtalbot mentioned this pull request Jul 13, 2017
Closed
@hugtalbot hugtalbot added the pr: status to review To notify reviewers to review this pull-request label Jul 13, 2017
@hugtalbot hugtalbot changed the title Remove ICPRegistration_ShapeMatching.scn from examples in Registration [ci-ignore] [examples] Remove ICPRegistration_ShapeMatching.scn from examples in Registration [ci-ignore] Jul 19, 2017
@hugtalbot hugtalbot changed the title [examples] Remove ICPRegistration_ShapeMatching.scn from examples in Registration [ci-ignore] [Registration] Remove ICPRegistration_ShapeMatching.scn from examples in Registration [ci-ignore] Jul 19, 2017
@damienmarchal damienmarchal merged commit 131043f into sofa-framework:master Jul 19, 2017
@guparan guparan modified the milestone: v17.12 Sep 13, 2017
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.
3 participants
@hugtalbot @guparan @damienmarchal