Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runSofa] remove non-ASCII chars in string #327

Merged
merged 1 commit into from
Jul 10, 2017
Merged

[runSofa] remove non-ASCII chars in string #327

merged 1 commit into from
Jul 10, 2017

Conversation

flm8620
Copy link
Contributor

@flm8620 flm8620 commented Jul 7, 2017 •
edited by damienmarchal
Loading

non-ASCII chars caused problems in some platform when compiling
Discussed in Issue323

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@flm8620
remove non-ASCII chars in string
36897ea 
non-ASCII chars caused problems in some platform when compiling
@sofabot
Copy link
Collaborator

sofabot commented Jul 7, 2017

Thank you for your pull request!
Someone will soon check it and start the builds.

@guparan
Copy link
Contributor

guparan commented Jul 7, 2017

Hi @flm8620 thank you for your first PR and welcome to the SOFA community 👏
I guess this will be merged soon :-)
[ci-build]

@guparan guparan added location: project pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug labels Jul 7, 2017
@guparan guparan changed the title remove non-ASCII chars in string [runSofa] remove non-ASCII chars in string Jul 7, 2017
@damienmarchal damienmarchal merged commit 505a44f into sofa-framework:master Jul 10, 2017
@damienmarchal
Copy link
Contributor

Yes, thank you...I merge it.

Just one comment, please don't issue PR from your master branch as this makes the dashboard report unclear. We recommand using a per branch per PR approach.

@flm8620
Copy link
Contributor Author

flm8620 commented Jul 10, 2017

Oh, thank you for pointing this out. This is my first PR on github.

matthieu-nesme pushed a commit to Anatoscope/sofa that referenced this pull request Aug 4, 2017
@damienmarchal @matthieu-nesme
Merge pull request sofa-framework#327 from flm8620/master
13caed3 
[runSofa] remove non-ASCII chars in string
(cherry picked from commit 505a44f)
@guparan guparan modified the milestone: v17.12 Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.
4 participants
@flm8620 @sofabot @guparan @damienmarchal