[SofaKernel] Improve File:line info in error message (for python and xml error reporting) #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he problematic file line number in the message.
|
[ci-build] |
damienmarchal
changed the title
damienmarchal
changed the title
damienmarchal
added
enhancement
6 tasks
|
[ci-build] |
|
Note: the build fail on OSX is due to API change in boost 1.64 that makes the Multithreading plugin fail to build. I would not pay attention to it until Multithreading is fixed. |
damienmarchal
added
pr: status ready
Closed
6 tasks
damienmarchal
added
pr: status to review
6 tasks
hugtalbot
added
pr: status ready
|
[ci-build] |
|
Fixed the conflict...let's rebuild |
|
Just a SOFA_FILE_INFO2 to replace with SOFA_FILE_INFO_COPIED_FROM in Binding_SofaModule.cpp |
|
great @damienmarchal , unfortunately ci is down for the day ! |
|
[ci-build] |
|
The CI finished but the dashboard is not up-to date. |
matthieu-nesme
pushed a commit
to Anatoscope/sofa
that referenced
this pull request
Aug 4, 2017
…ation [SofaKernel] Improve File:line info in error message (for python and xml error reporting) (cherry picked from commit 6e9ac71)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when object are unable to be created there is no filename/line information on where the problem come from.
In this PR I implemented the missing <<operator in messaging.h to report those line number.
Now you can write:
To have the file name & line number associated in the message emitting information. If you don't the emitting information will be the source code file&line location.
If updated the xml load to take this feature into account.
The python loader is updated in the PR #304
This PR:
Reviewers will merge only if all these checks are true.