Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaExporter] FIX allow to extend VTKExporter in a plugin #309

Merged
merged 1 commit into from
Jul 5, 2017
Merged

[SofaExporter] FIX allow to extend VTKExporter in a plugin #309

merged 1 commit into from
Jul 5, 2017

Conversation

untereiner
Copy link

@untereiner untereiner commented Jun 29, 2017 •
edited by damienmarchal
Loading

FIX allows to extend VTKExporter in a plugin (for quadratic meshes for example)

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@damienmarchal damienmarchal added the pr: status ready Approved a pull-request, ready to be squashed label Jun 30, 2017
@damienmarchal
Copy link
Contributor

damienmarchal commented Jun 30, 2017 •
edited
Loading

This looks ok to me. So I set it to ready.

@guparan guparan changed the title [SofaExporter] FIX allows to extend VTKExporter in a plugin (for quad… [SofaExporter] FIX allow to extend VTKExporter in a plugin Jul 3, 2017
@guparan guparan added the pr: fix Fix a bug label Jul 3, 2017
@guparan guparan merged commit 96de56c into sofa-framework:master Jul 5, 2017
@guparan guparan added this to the v17.12 milestone Jul 5, 2017
@untereiner untereiner deleted the fix_vtkExporter branch July 5, 2017 10:03
matthieu-nesme pushed a commit to Anatoscope/sofa that referenced this pull request Aug 4, 2017
@guparan @matthieu-nesme
Merge pull request sofa-framework#309 from mimesis-inria/fix_vtkExporter
6f8a968 
[SofaExporter] FIX allow to extend VTKExporter in a plugin
@guparan guparan modified the milestone: v17.12 Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.12
Development

Successfully merging this pull request may close these issues.
3 participants
@untereiner @damienmarchal @guparan