-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[all] Fix rgbacolor parsing #305
Merged
guparan
merged 6 commits into
sofa-framework:master
from
SofaDefrost:fix_rgbacolor_parsing
Jun 28, 2017
Merged
[all] Fix rgbacolor parsing #305
guparan
merged 6 commits into
sofa-framework:master
from
SofaDefrost:fix_rgbacolor_parsing
Jun 28, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move it from core/loader to helper/types - Add backward compatibility to the preserve the existing API. - Add tests to this class. - Move the code into a .cpp instead of the .h
damienmarchal
added
pr: fast merge
Minor change that can be merged without waiting for the 7 review days
pr: fix
Fix a bug
pr: status to review
To notify reviewers to review this pull-request
labels
Jun 15, 2017
I'm so tired of windows.
Thanks for your PR @damienmarchal |
No-one answered so it means you can merge it :) |
Closed
hugtalbot
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: fast merge
Minor change that can be merged without waiting for the 7 review days
pr: fix
Fix a bug
pr: status ready
Approved a pull-request, ready to be squashed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression in the way RGBAColor are parsed by the stream operator>>.
This was the cause of Material reading was not working (issue #302).
This PR fix:
This PR:
Reviewers will merge only if all these checks are true.