-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaSimpleFem] ADD computeBBox and test to HexaFEMForceField #289
[SofaSimpleFem] ADD computeBBox and test to HexaFEMForceField #289
Conversation
I like new tests so thanks for your PR. |
Rebased and cleaned. |
@@ -343,6 +343,8 @@ class HexahedronFEMForceField : virtual public core::behavior::ForceField<DataTy | |||
void addKToMatrix(const core::MechanicalParams* mparams, const sofa::core::behavior::MultiMatrixAccessor* matrix); | |||
|
|||
|
|||
void computeBBox(const core::ExecParams* params, bool); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing bool name onlyVisible and if false return
[ci-build] |
This PR is not ready, it seems to mess with the CI. See all latest failing builds (239 => 243) on windows7_VS-2015_amd64_pr_1_options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor change required
helper::ReadAccessor<DataVecCoord> x = this->mstate->read(core::VecCoordId::position()); | ||
|
||
static const Real max_real = std::numeric_limits<Real>::max(); | ||
static const Real min_real = std::numeric_limits<Real>::min(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning std::numeric_limits::min()
is not what you want, you want either -std::numeric_limits::max()
or in c++11 std::numeric_limits::lowest()
Hi all, Is this PR ready ? |
Do you agree @matthieu-nesme ? |
[ci-build] |
This PR fullfill our merging rules...so I pass it to ready. |
[SofaSimpleFem] ADD computeBBox and test to HexaFEMForceField
add bounding box to hexaFemForceField
This PR:
Reviewers will merge only if all these checks are true.