-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mass] Fix point topological changes for UniformMass #2853
[Mass] Fix point topological changes for UniformMass #2853
Conversation
Thank you for this PR, it highlights a more serious bug when adding elements in TopologySubsetData. A PR to fix the TopologySubsetData is coming, then we will update this PR to adapt UniformMass with the good callbacks. Right now the callback on PointRemoved event proposed in this PR will crash as the TopologySubsetData already has an internal mechanism to update its size. So you perform the deletion twice. |
Update the FIX but now this PR depends on change done in PR #2870 |
@hugtalbot now that #2869 has been merged, you can review the #2870, then this one will be the following... |
[ci-build][with-all-tests] |
ece45e7
to
9d4e313
Compare
…e an option of UniformMass. Support is automatic if the mass is linked to a dynamic topology
9d4e313
to
5ce37c0
Compare
@hugtalbot this one is ready for me. Could you double check and merge? |
Based on #2870
The topological callback was actually not working for the UniformMass.
Now POINTSADDED and POINTSREMOVED are handled
in addition:
Thanks to @Oparras for rising this in #2668
A regression could be added on this scene
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if