Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Mouse picking on Mechanical Object #282

Merged
merged 1 commit into from
Jun 2, 2017
Merged

FIX: Mouse picking on Mechanical Object #282

merged 1 commit into from
Jun 2, 2017

Conversation

olivier-goury
Copy link
Contributor

Solves issue #84

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@sofabot
Copy link
Collaborator

sofabot commented Jun 1, 2017

Thank you for your pull request!
Someone will soon check it and start the builds.

@damienmarchal damienmarchal added issue: bug (major) Critical bug affecting everyone: not working, performances or accuracy degraded pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed and removed issue: bug (major) Critical bug affecting everyone: not working, performances or accuracy degraded labels Jun 1, 2017
@bcarrez bcarrez added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Jun 1, 2017
@damienmarchal
Copy link
Contributor

Congratulation Olivier for your two PRs in a row.

If there is an open issue that is related with this fix you can connect it so that when the PR is merge...the corresponding issue is closed.

@hugtalbot I think you can merge this one bypassing our traditional reviewing process :)

[ci-build]

@bcarrez
Copy link
Contributor

bcarrez commented Jun 1, 2017

This PR is so simple I cannot imagine anything that would go against its fast merging.

@matthieu-nesme
Copy link
Member

indeed, nice finding :)

@maxime-tournier
Copy link
Contributor

Thank you so much for this, it had been bugging me for ages!

@bcarrez
Copy link
Contributor

bcarrez commented Jun 2, 2017

So... I take the responsibility to merge it. Blame me if I break something.

@bcarrez bcarrez merged commit eee213f into sofa-framework:master Jun 2, 2017
hugtalbot pushed a commit that referenced this pull request Jun 7, 2017
Update changelog with PR #270, #273, #275 and #282
ccb2394
marques-bruno pushed a commit to mimesis-inria/sofa that referenced this pull request Jun 29, 2017
@marques-bruno
Update changelog with PR sofa-framework#270, sofa-framework#273, sofa…
70409a0 
…-framework#275 and sofa-framework#282
@guparan guparan added this to the v17.06 milestone Jun 29, 2017
@damienmarchal damienmarchal deleted the fixMousePicking branch July 5, 2017 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hugtalbot hugtalbot

Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.06
Development

Successfully merging this pull request may close these issues.
8 participants
@olivier-goury @sofabot @damienmarchal @bcarrez @matthieu-nesme @maxime-tournier @guparan @hugtalbot