Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaHelper_test] Remove temporary file in FileMonitor_test #2537

Merged
merged 1 commit into from
Dec 13, 2021
Merged

[SofaHelper_test] Remove temporary file in FileMonitor_test #2537

merged 1 commit into from
Dec 13, 2021

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Dec 13, 2021

Mostly because it bothered me when i was doing git status...

But also because it does not really make sense that a file is created in the source directory

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Dec 13, 2021
@guparan guparan merged commit 0f6f84a into sofa-framework:master Dec 13, 2021
@guparan guparan added this to the v21.12 milestone Dec 13, 2021
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 13, 2021
@fredroy fredroy deleted the remove_existingfile_test branch December 13, 2021 10:59
fredroy added a commit to fredroy/sofa that referenced this pull request Dec 13, 2021
@fredroy
[SofaHelper_test] Remove temporary file in FileMonitor_test (sofa-fra…
6932441 
…mework#2537)

Mostly because it bothered me when i was doing `git status`...

But also because it does not really make sense that a file is created in the source directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan approved these changes

@alxbilger alxbilger alxbilger approved these changes

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.12
Development

Successfully merging this pull request may close these issues.
3 participants
@fredroy @guparan @alxbilger