Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[image] Clean init members warning #2536

Merged
merged 1 commit into from
Dec 13, 2021
Merged

[image] Clean init members warning #2536

merged 1 commit into from
Dec 13, 2021

Conversation

maddin200
Copy link
Contributor

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@guparan
Copy link
Contributor

guparan commented Dec 10, 2021

Please @maddin200 avoid spamming micro-pull-requests.
Your warning fixes are very welcome and appreciated but could you try doing more than one in the same PR?
Thank you 👌

@guparan guparan added pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Dec 10, 2021
@guparan guparan changed the title [image] init members [image] Clean init members warning Dec 10, 2021
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 10, 2021
@guparan guparan added this to the v21.12 milestone Dec 10, 2021
@guparan guparan merged commit 5392338 into sofa-framework:master Dec 13, 2021
fredroy pushed a commit to fredroy/sofa that referenced this pull request Dec 13, 2021
@maddin200 @fredroy
[image] Clean init members warning (sofa-framework#2536)
b2c21bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.12
Development

Successfully merging this pull request may close these issues.
2 participants
@maddin200 @guparan