Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugins] Remove LMConstraint from SOFA repository #2508

Merged
merged 2 commits into from
Dec 9, 2021
Merged

[plugins] Remove LMConstraint from SOFA repository #2508

merged 2 commits into from
Dec 9, 2021

Conversation

hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented Nov 26, 2021 •
edited by fredroy
Loading

Prepare outsourcing of the LMConstraint plugin
New plugin is now available at ➡️ https://github.com/sofa-framework/LMConstraint

(#1527 , #1442)

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress pr: clean Cleaning the code labels Nov 26, 2021
@hugtalbot hugtalbot added this to the v22.06 milestone Nov 26, 2021
@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Nov 26, 2021
@hugtalbot
Copy link
Contributor Author

[ci-build]

@fredroy fredroy added the NG4: remove-plugins See https://github.com/sofa-framework/sofa/issues/1527 label Dec 1, 2021
@fredroy
Copy link
Contributor

fredroy commented Dec 1, 2021

So starting from now LMConstraint is not activated by default? (not that I am against it 😗)
Actually, it will even not appear in the cmake of SOFA, this is what you planned?

@hugtalbot
Copy link
Contributor Author

Yes, this is my plan @fredroy !
I want to see LMConstraint disappear - and quickly ! 💥

@fredroy
Copy link
Contributor

fredroy commented Dec 3, 2021

[ci-build][with-all-tests]

@hugtalbot hugtalbot modified the milestones: v22.06, v21.12 Dec 8, 2021
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Dec 9, 2021
@guparan guparan merged commit a02af10 into sofa-framework:master Dec 9, 2021
alxbilger added a commit to alxbilger/sofa that referenced this pull request Apr 1, 2022
@alxbilger
[LMConstraint] Remove LMConstraint folder as it is an external plugin
a57cb66 
See https://github.com/sofa-framework/LMConstraint and sofa-framework#2508
@alxbilger alxbilger mentioned this pull request Apr 1, 2022
Merged
fredroy pushed a commit that referenced this pull request Apr 1, 2022
@alxbilger
[LMConstraint] Remove LMConstraint folder as it is an external plugin (…
0a28149 
…#2828)

See https://github.com/sofa-framework/LMConstraint and #2508
EulalieCoevoet pushed a commit to EulalieCoevoet/sofa that referenced this pull request Apr 20, 2022
@alxbilger @EulalieCoevoet
[LMConstraint] Remove LMConstraint folder as it is an external plugin (…
1d3e22e 
…sofa-framework#2828)

See https://github.com/sofa-framework/LMConstraint and sofa-framework#2508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
NG4: remove-plugins See https://github.com/sofa-framework/sofa/issues/1527 pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.12
Development

Successfully merging this pull request may close these issues.
3 participants
@hugtalbot @fredroy @guparan