[all] Variable can be made constexpr #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbilger
added
pr: fast merge
hugtalbot
approved these changes
Nov 9, 2021
hugtalbot
added
pr: status ready
fredroy
added
pr: status to review
|
as @fredroy noticed, a compilation issue appeared on ubuntu @alxbilger |
hugtalbot
added
pr: status wip
fredroy
reviewed
Nov 10, 2021
| @@ -43,7 +43,7 @@ namespace sofa | |||
| namespace helper | |||
| { | |||
|
|
|||
| const unsigned long RandomGenerator::RANDOM_BASE_MAX = 4294967295U; | |||
| constexpr unsigned long RandomGenerator::RANDOM_BASE_MAX = 4294967295U; | |||
There was a problem hiding this comment.
RANDOM_BASE_MAX is declared static in the header.
you could move the initialization in the .h (inline static initialization) I suppose.
Funnily only gcc was bothered 🤫
alxbilger
added
pr: status to review
|
[ci-build][with-all-tests] |
fredroy
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My IDE found that some variables could be made
constexpr.By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if