Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Speedup the caduceus #2471

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

alxbilger
Copy link
Contributor

In the caduceus scene, the collision detection and the free motion can be computed in parallel.

Here are the timings for 1000 time steps on my computer:

Before

 LEVEL   START    NUM      MIN     MAX   MEAN     DEV    TOTAL  PERCENT ID
   0       0    1000       1.43    8.29    2.27    0.44 2266.53  100    TOTAL
   1       0       1       1.43    8.27    2.27    0.44    2.27   99.95 .Simulation::animate
   2       0.06    1       1.05    6.97    1.28    0.22    1.28   56.46 ..FreeMotion+CollisionDetection

[INFO] [BatchGUI] 1000 iterations done in 2.57462 s ( 388.407 FPS).

After

 LEVEL   START    NUM      MIN     MAX   MEAN     DEV    TOTAL  PERCENT ID
   0       0    1000       1.21    7.79    1.95    0.39 1948.88  100    TOTAL
   1       0       1       1.21    7.78    1.95    0.39    1.95   99.95 .Simulation::animate
   2       0.06    1       0.80    6.66    0.99    0.21    0.99   50.72 ..FreeMotion+CollisionDetection

[INFO] [BatchGUI] 1000 iterations done in 2.24415 s ( 445.602 FPS).


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request labels Nov 9, 2021
@hugtalbot
Copy link
Contributor

same remark than in #2470 but I am fine with it 👍
(except that this scene example is 💩-unstable @fredroy we must create this new SOFA starting scene ;)

@alxbilger
Copy link
Contributor Author

same remark than in #2470 but I am fine with it 👍 (except that this scene example is 💩-unstable @fredroy we must create this new SOFA starting scene ;)

Go Go Go!

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 10, 2021
@fredroy fredroy merged commit 330a09c into sofa-framework:master Nov 10, 2021
@guparan guparan added this to the v21.12 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants