Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaTopologyMapping] Fix Tetra2TriangleTopologicalMapping lost ancestor info #2460

Merged
merged 2 commits into from
Nov 19, 2021
Merged

[SofaTopologyMapping] Fix Tetra2TriangleTopologicalMapping lost ancestor info #2460

merged 2 commits into from
Nov 19, 2021

Conversation

epernod
Copy link
Contributor

@epernod epernod commented Nov 7, 2021

Ancestors and coefficient parameters were lost during EdgeAdded and PointAdded methods coming from Tetrahedron to Triangle mesh.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@epernod epernod added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request labels Nov 7, 2021
@epernod epernod self-assigned this Nov 7, 2021
fredroy
fredroy requested changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@fredroy fredroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TopologyChange's stuff is now in Sofa.Core

modules/SofaTopologyMapping/src/SofaTopologyMapping/Tetra2TriangleTopologicalMapping.cpp Outdated Show resolved Hide resolved
modules/SofaTopologyMapping/src/SofaTopologyMapping/Tetra2TriangleTopologicalMapping.cpp Outdated Show resolved Hide resolved
@epernod @fredroy
Apply suggestions from code review
2e1e339 
Co-authored-by: Frederick Roy <fredroy@users.noreply.github.com>
@fredroy
Copy link
Contributor

fredroy commented Nov 19, 2021

[ci-build][with-all-tests]

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Nov 19, 2021
@fredroy fredroy merged commit f181300 into sofa-framework:master Nov 19, 2021
@guparan guparan added this to the v21.12 milestone Dec 9, 2021
@guparan guparan changed the title [TopologyMapping] Fix Tetra2TriangleTopologicalMapping lost ancestor info [SofaTopologyMapping] Fix Tetra2TriangleTopologicalMapping lost ancestor info Dec 10, 2021
@epernod epernod deleted the inf_fixTopoMapping branch January 14, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredroy fredroy fredroy requested changes

Assignees

@epernod epernod

Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v21.12
Development

Successfully merging this pull request may close these issues.
3 participants
@epernod @fredroy @guparan