[SofaLoader] Rename MeshObjLoader to MeshOBJLoader #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: breaking
alxbilger
approved these changes
Oct 18, 2021
|
[ci-build][with-all-tests] |
|
ObjMeshLoader ? 😆 |
hugtalbot
requested changes
Nov 3, 2021
guparan
suggested changes
Nov 3, 2021
hugtalbot
added
pr: status wip
fredroy
force-pushed
the
rename_objloader
branch
from
cba24aa
to
e5b8e7c
Compare
fredroy
added
pr: status to review
|
As expected, it is not possible to do a forward file (MeshObjLoader to MeshOBJLoader) for Windows (and Mac) because of the case insensitivity... 🥺 |
|
And MeshGmsh, Off, Xsp are next? |
fredroy
added
pr: status wip
…sname)" This reverts commit d69d69b.
fredroy
force-pushed
the
rename_objloader
branch
from
e5b8e7c
to
5a06631
Compare
fredroy
removed
the
pr: status wip
fredroy
added
the
pr: status to review
…oader # Conflicts: # applications/plugins/CGALPlugin/scenes/BooleanOperations.scn # applications/plugins/CGALPlugin/scenes/FrontSurfaceReconstruction.scn # applications/plugins/CGALPlugin/scenes/MeshGenerationFromPolyhedron.scn # applications/plugins/CGALPlugin/scenes/PoissonSurfaceReconstruction.scn # applications/plugins/CGALPlugin/scenes/UpsamplePointCloud.scn
hugtalbot
added
pr: status ready
bakpaul
pushed a commit
to bakpaul/sofa
that referenced
this pull request
Feb 23, 2024
All loaders/exporters consider the file format in upper-case EXCEPT MeshObjLoader. When you have stuff like MeshVTKLoader, MeshOBJ, OBJExporter, MeshSTLLoader, ImagePNG, etc it looks not consistent. So this PR renames all occurrences of MeshObjLoader to MeshOBJLoader and add an alias with `MeshObjLoader` to keep the compatibility with the existing scenes. Otherwise, all the other upper-case should be converted to Xxx but will be much more bothersome that this PR....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All loaders/exporters consider the file format in upper-case EXCEPT MeshObjLoader.
When you have stuff like MeshVTKLoader, MeshOBJ, OBJExporter, MeshSTLLoader, ImagePNG, etc
it looks not consistent.
So this PR renames all occurrences of MeshObjLoader to MeshOBJLoader and add an alias with
MeshObjLoaderto keep the compatibility with the existing scenes.Otherwise, all the other upper-case should be converted to Xxx but will be much more bothersome that this PR....
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if